New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Antisymmetrise ERI tensor inside adccore during import #39
Conversation
Some current timings on my laptop: ccpVQZ water (restricted)New version (this branch)
Old version (master)
def2-tzvp CH2NH2 radical (unrestricted)New version (this branch)
Old version (master)
Memory water ADC2 this branchMemory water ADC2 masterMemory CH2NH2 radical ADC3 this branchMemory CH2NH2 radical ADC3 masterSo adding them all up, for UHF the new version is better in timings. For RHF the total time is roughly the same. When it comes to memory, the requirement is greatly reduced for RHF and about similar for UHF with this PR. |
167d985
to
caa96d5
Compare
ed3328f
to
f7665c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I trust you that the benchmarks are okay, nice to get rid of some code on the Python layer.
- Full API reference for adcc - Reference to benchmark results
ab624ec
to
ebdf37b
Compare
Just a final comment: On the noradrenaline testcase, this brought down the memory requirement from 398GB to 280GB (ca. -30%) 😄. |
Antisymmetrise not on the python side but during the import into libtensor memory.