Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small workaround using OMXPlayer #7

Merged
merged 1 commit into from
Mar 25, 2020

Conversation

dagwieers
Copy link
Collaborator

@dagwieers dagwieers commented Mar 20, 2020

This is a workaround that improves playback on Raspberry Pi and older on Kodi v18 and older.

This works on Raspberry Pi, needs to be tested on RPi4 and non-RPi.

This relates to #4

@dagwieers dagwieers added bug Something isn't working kodi Related to the Kodi media player arm Related to ARM architecture labels Mar 20, 2020
@michaelarnauts
Copy link
Collaborator

This doesn't seem to give any issues on my linux x64 install.

Does omxplayer also work if we would switch to Inputstream Adaptive?

@dagwieers
Copy link
Collaborator Author

I think so, it did on Retrospect AFAICT.

@dagwieers
Copy link
Collaborator Author

It doesn't give issues because even if the option was there, it wouldn't work.

We may want to make this a setting (so the user can influence the behaviour) or provide a notification that we changed this global setting. Maybe set_global_setting should always notify the user when changing settings?

@michaelarnauts
Copy link
Collaborator

I wouldn't always show a notification, this is annoying when you switch between Netflix (that does the opposite).

A setting to turn this behaviour on could be useful though. Maybe we can even hide this setting in non-rpi devices?

@dagwieers dagwieers force-pushed the omxplayer-fix branch 4 times, most recently from f03cf3a to a682f46 Compare March 24, 2020 20:46
@michaelarnauts
Copy link
Collaborator

@dagwieers could you rebase on master please?

@dagwieers
Copy link
Collaborator Author

Done !

@michaelarnauts michaelarnauts merged commit 3281c41 into add-ons:master Mar 25, 2020
@michaelarnauts michaelarnauts added this to the v0.1.0 milestone Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arm Related to ARM architecture bug Something isn't working kodi Related to the Kodi media player
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants