Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback for live streams when web scraping fails #168

Merged
merged 1 commit into from May 1, 2019

Conversation

dagwieers
Copy link
Collaborator

@dagwieers dagwieers commented May 1, 2019

This implements vualto live stream support (by video_id) for streams
that do not rely on web scraping, but also implements a fallback
mechanism in case web scraping fails.

This is the last piece to get rid of any reliance on web scraping.
Users everywhere rejoice !

This fixes #57

@dagwieers dagwieers requested a review from pietje666 May 1, 2019 13:35
@dagwieers
Copy link
Collaborator Author

@mediaminister Please test!

I tested this by enabling (non-working) stubru and mnm livestreams. And it correctly falls back to using the provided video_id.

@dagwieers dagwieers added the enhancement New feature or request label May 1, 2019
This implements vualto live stream support (by video_id) for streams
that do not rely on web scraping, but also implements a fallback
mechanism in case web scraping fails.

This is the last piece to get rid of any reliance on web scraping.
Users everywhere rejoice !
@dagwieers
Copy link
Collaborator Author

I am going to merge this, so I can test everything (including Radio support) in a single build.
Feedback and improvements welcome !

@dagwieers dagwieers merged commit d28a0d9 into add-ons:master May 1, 2019
@mediaminister
Copy link
Collaborator

mediaminister commented May 1, 2019

This code can't work. You can't return streamurls before we check roaming, etc...
I'll provide a pull request with a fix.

@dagwieers
Copy link
Collaborator Author

@mediaminister OK, this affects only the fallback for the original streams. We can fix this.

@mediaminister
Copy link
Collaborator

Maybe it affects more than that. I'm testing at the moment.

@dagwieers
Copy link
Collaborator Author

No, it worked fine (as a fallback) for the MNM and Studio Brussel streams, and only is used as a fallback for the original streams. So yes, we need to fix this, it definitely fails to fallback.

@mediaminister
Copy link
Collaborator

mediaminister commented May 1, 2019

We never used web scraping for MNM and Studio Brussel, it never executed your fall back code.

@dagwieers
Copy link
Collaborator Author

dagwieers commented May 1, 2019

Well, for testing I added the live URL that obviously fails to be scraped correctly.
That is how I tested where and how to inject it, but it is insufficient for the original streams.

@dagwieers
Copy link
Collaborator Author

I'll be back later this evening.

@mediaminister
Copy link
Collaborator

I found out what was wrong and created a fix: #170

@dagwieers
Copy link
Collaborator Author

I wondered what the _geo streams were, apparently they are the solution ;-)

@dagwieers dagwieers added this to the 1.9.0 milestone May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use VRT NU API instead of scraping
2 participants