Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean url router #314

Merged
merged 2 commits into from Jun 17, 2019
Merged

Clean url router #314

merged 2 commits into from Jun 17, 2019

Conversation

mediaminister
Copy link
Collaborator

This implements the new router design as discussed in #103

@dagwieers dagwieers added the enhancement New feature or request label Jun 17, 2019
@dagwieers dagwieers added this to the v2.0.0 milestone Jun 17, 2019
@dagwieers
Copy link
Collaborator

Oh god, I broke it really good. Need to think about how to add refresh in this new scheme.

@dagwieers
Copy link
Collaborator

dagwieers commented Jun 17, 2019

Let me offer a fix for this the coming week.

I think we can use the existing scheme and merge it with the CACHES database as it was implemented. I just need to add @plugin.router() entries for most of what is in vrtplayer.py and add my own for the refresh-part. (Trying to combine refresh with the existing logic is way to invasive, so I am not going to try that with the new scheme).

@mediaminister
Copy link
Collaborator Author

mediaminister commented Jun 17, 2019

Oh god, I broke it really good.

I think i fixed it. Don't overcomplicate things.

@dagwieers
Copy link
Collaborator

Well, I don't like the fact that we have an interface now for removing arbitrary files.
So let's merge this and then see how we can improve things.

@dagwieers
Copy link
Collaborator

And thanks for fixing this. The quick succession of changes really speeds up development.

@dagwieers dagwieers merged commit c6e2f46 into add-ons:master Jun 17, 2019
@mediaminister
Copy link
Collaborator Author

mediaminister commented Jun 17, 2019

Thanks for merging, now we can move forward with the new interface.
The cache refresh could surely be improved. For instance the container refresh doesn't refresh the tvguide caching file.

@dagwieers
Copy link
Collaborator

@mediaminister I am rewriting using the routing module now and it is even looking more fabulous :-)
Hope I can test this in an hour and share it here.

@mediaminister mediaminister deleted the router branch August 11, 2019 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants