Making settings instantaneous #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR doesn't store settings once on activation, but reevalutes settings on use. I don't know what the performance impact is, but since it is backed by C++ I would expect this to be efficient :-)
|
With this change you can go to the settings enable/disable features and you will see the impact instantly when returning from the settings. The listing will e.g. update without favorites when you disable them, or without watching activity items when disabling resumepoints. Just as one would expect. This was required after we enabled |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR doesn't store settings once on activation, but reevalutes
settings on use. I don't know what the performance impact is, but since
it is backed by C++ I would expect this to be efficient :-)
This fixes #560