Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for v1.1.5 #225

Merged
merged 1 commit into from
Oct 21, 2020
Merged

Prepare for v1.1.5 #225

merged 1 commit into from
Oct 21, 2020

Conversation

mediaminister
Copy link
Contributor

No description provided.

@mediaminister
Copy link
Contributor Author

mediaminister commented Oct 21, 2020

Unit tests ran fine: https://github.com/mediaminister/plugin.video.vtm.go/runs/1285309964

2020-10-21T07:09:28.5471130Z Ran 27 tests in 27.492s
2020-10-21T07:09:28.5471335Z 
2020-10-21T07:09:28.5471549Z OK

Testing master branch in VM's now:

  • Add to mylist is broken

@michaelarnauts
Copy link
Collaborator

Testing master branch in VM's now:

  • Add to mylist is broken

It seems that even when the API_ENDPOINT is prefixed, it still doesn't work. The DELETE returns 204, but the actual listing doesn't change. The Android app uses the new endpoints for this, maybe this is the reason, and the old API isn't syncing anymore with the new one?

@mediaminister
Copy link
Contributor Author

The api has changed, post requests are used now, but I guess there is some kind of authentication needed now:
https://vtm.be/vtmgo/userData/myList/program/343858f4-b704-452e-a1bc-e3a1e765ce9f/add
https://vtm.be/vtmgo/userData/myList/program/343858f4-b704-452e-a1bc-e3a1e765ce9f/remove

@michaelarnauts
Copy link
Collaborator

The api has changed, post requests are used now, but I guess there is some kind of authentication needed now:
https://vtm.be/vtmgo/userData/myList/program/343858f4-b704-452e-a1bc-e3a1e765ce9f/add
https://vtm.be/vtmgo/userData/myList/program/343858f4-b704-452e-a1bc-e3a1e765ce9f/remove

This is using the website API. I think we better fix this by using the underlying API (https://lfvp-api.dpgmedia.net) like you did in your PR, but maybe not for the streams, se we can keep on using the current way of playing the advertisements?

@mediaminister
Copy link
Contributor Author

Okay, this is possible. I'll make a PR.

@michaelarnauts
Copy link
Collaborator

Okay, this is possible. I'll make a PR.

Hold on, the fix is easy. We weren't passing our tokens to the DELETE and PUT call.

@michaelarnauts
Copy link
Collaborator

See #227

@mediaminister
Copy link
Contributor Author

That was it, it works again.

@michaelarnauts michaelarnauts merged commit 5224bc9 into add-ons:master Oct 21, 2020
@michaelarnauts michaelarnauts added the release Related to release management label Nov 11, 2020
@michaelarnauts michaelarnauts added this to the v1.1.5 milestone Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Related to release management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants