Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various authentication improvements #253

Merged
merged 1 commit into from
Jan 7, 2021
Merged

Conversation

michaelarnauts
Copy link
Collaborator

  • Fix duplicate log entries
  • Don't run VtmGoAuth.login() twice, but use VtmGoAuth.get_tokens() instead
  • Remove duplicated response.raise_for_status()
  • Don't save credential hash when login was not successful.
  • Remove unused VtmGoAuth.clear_token()

@michaelarnauts michaelarnauts added the enhancement New feature or request label Jan 7, 2021
@michaelarnauts michaelarnauts merged commit 9b67091 into master Jan 7, 2021
@michaelarnauts michaelarnauts deleted the auth-improvements branch January 7, 2021 18:08
@dagwieers dagwieers added this to the v1.2.3 milestone Jan 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants