Don't depend on credentials to populate IPTV Manager data #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelarnauts
force-pushed
the
no-errors-on-empy-config
branch
from
fafb0f2
to
d6da286
Compare
|
Similar problem with Yelo. On a default installation, if you enable IPTV Manager before adding credentials to Yelo, you get pop-ups from Yelo to add credentials. And it is very hard to get rid of it, especially if you happen to not have (working) credentials. The use of IPTV Manager should not cause add-ons to give pop-up windows. I think we need to clarify this bit in our IPTV Manager documentation, and open an issue with the Yelo add-on. Providing an exception for this would be best, so the problem is visible and gets logged. |
|
In this case, I don't need to send a token, so I can just query the EPG and Channel listing without credentials. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a clean install, when there are no credentials filled in, and IPTV Manager is querying for information, an exception is raised to indicate that there are no credentials.
We don't need to do this, since we can query the channels and EPG fine without credentials. Credentials will be asked when a channel or VOD is played for the first time.