Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework to use new authentication, remove broken features. #311

Merged
merged 5 commits into from Dec 19, 2021

Conversation

michaelarnauts
Copy link
Collaborator

@michaelarnauts michaelarnauts commented Nov 25, 2021

Changes:

  • Implemented new login flow
  • Removed catalog features (since the endpoint has been removed)
  • Removed library support (again, the catalog endpoint has been removed)
  • Removed metadata caching (again, the catalog endpoint has been removed)
  • Always uses the main profile (kids can be selected in the main menu)

Update 2021-11-27

plugin.video.vtm.go-1.3+matrix.1-rework-e3ee17c.zip
plugin.video.vtm.go-1.3-rework-e3ee17c.zip

@michaelarnauts
Copy link
Collaborator Author

michaelarnauts commented Nov 25, 2021

For some brave souls who want to try this out:
plugin.video.vtm.go-1.2.12+matrix.1-rework-8563c0d.zip
plugin.video.vtm.go-1.2.12-rework-8563c0d.zip

EDIT: Use latest zips above.

@Bart80-1
Copy link

I tested this on Linux (Mint 20.2) with Kodi 19 + RPi4 with LibreElec 10.
Login works nicely, but after the code is entered in the VTM-Go website and the dialogbox in Kodi is answered with "Yes refresh", the dialogsbox keeps reappearing. Clicking "No" solves it.
A-Z is indeed removed (makes sense if VTM-Go dropped it).
Subtitles worked again! At least under Linux.
On LibreElec10 i got it working for Timeless episide 2x08 "The day Reagan was shot" and Aspe S6E06 ("De Valkenier"). S6E13 ("De architect (deel 2)") did not display the subtitles - however, it works under Linux.

Anything else in particular you need testing for?

@michaelarnauts
Copy link
Collaborator Author

I tested this on Linux (Mint 20.2) with Kodi 19 + RPi4 with LibreElec 10. Login works nicely, but after the code is entered in the VTM-Go website and the dialogbox in Kodi is answered with "Yes refresh", the dialogsbox keeps reappearing. Clicking "No" solves it. A-Z is indeed removed (makes sense if VTM-Go dropped it). Subtitles worked again! At least under Linux. On LibreElec10 i got it working for Timeless episide 2x08 "The day Reagan was shot" and Aspe S6E06 ("De Valkenier"). S6E13 ("De architect (deel 2)") did not display the subtitles - however, it works under Linux.

Anything else in particular you need testing for?

Cool. Thanks for testing. I haven't looked at the search, and I didn't look at the recommendation menu's.

Odd that the login behaved like that. It should redirect to the main menu after selecting refresh, but I have only minimally tested it, so it can be improved a lot.

@cometoluc
Copy link

Hello,

i tried to use plugin.video.vtm.go-1.2.12+matrix.1-rework-8563c0d.zip and also
plugin.video.vtm.go-1.2.12-rework-8563c0d.zip, but

i work in windows 7 32 pc with latest kodi

@michaelarnauts
Copy link
Collaborator Author

I've uploaded new zips at the PR start. See #311 (comment)

@Bart80-1
Copy link

I noticed that I could no longer use the first version of the addon.
Error log here: https://paste.kodi.tv/leparapoqu
Error is
Error Contents: 401 Client Error: Unauthorized for url: https://lfvp-api.dpgmedia.net/vtmgo/tokens .

Is it possible that the token expires after 24 hours? That is more or less the time that has run between my first tests and now...

I installed the newer version. With the new one I was succesfully able to remove the authentication tokens and re-login (this didn't work with the first one).
After Sunday evening I'll be able to tell you if the token expiry problem after 24 hour still persists ;)

@michaelarnauts
Copy link
Collaborator Author

I noticed that I could no longer use the first version of the addon. Error log here: https://paste.kodi.tv/leparapoqu Error is Error Contents: 401 Client Error: Unauthorized for url: https://lfvp-api.dpgmedia.net/vtmgo/tokens .

Is it possible that the token expires after 24 hours? That is more or less the time that has run between my first tests and now...

I installed the newer version. With the new one I was succesfully able to remove the authentication tokens and re-login (this didn't work with the first one). After Sunday evening I'll be able to tell you if the token expiry problem after 24 hour still persists ;)

That was indeed an issue with the first version, and should be fixed in this one. But it's good to have this tested on more systems :) Thanks!

@cometoluc
Copy link

Hello,

i did the addon and vtmgo seemd to work again, but today i found out that i can not see the live channels

i work on windows7 32 pc with latest kodi

@frankdpGH
Copy link

Hi Michael, tested plugin.video.vtm.go-1.3+matrix.1-rework-e3ee17c.zip on a Android box (Android 9 ARM 64-bit).
Authentication method works perfect. OK with no Lib support (better than having all these error messages).
Subtitles are working again for VOD starting from the addon guide.
Subtitles not working when starting from EPG IPTV manager (had this issue already before, and using work around )(#308 (comment))
Attach a test log for subtitles :
19:07 starting movie MIB from VTMGO addon at 19:12 Subtitles are visible and working
19:14 starting movie MIB form EPG / IPTV mgr at 19:18 no subtitles working
kodi.log

@badoneti
Copy link

badoneti commented Dec 1, 2021

Accidentally found this update and tried it out. Worked well on x86-64, LibreElec 10.0.1 Kodi 19.3
Both the authentication mechanism and subtitles work again, thanks a lot for the efforts 👍 !
A pitty that the library integration had to be dropped. A matter of priorities as well I assume.

@michaelarnauts
Copy link
Collaborator Author

Accidentally found this update and tried it out. Worked well on x86-64, LibreElec 10.0.1 Kodi 19.3 Both the authentication mechanism and subtitles work again, thanks a lot for the efforts 👍 ! A pitty that the library integration had to be dropped. A matter of priorities as well I assume.

I need to some more testing, and will probably be able to release this soon.

Regarding the library Integration, did you actually buse this? My experience with it was that it didn't always correctly pick up new episodes, so I wasn't sure if it was actually being used by users.

@badoneti
Copy link

badoneti commented Dec 1, 2021

Regarding the library Integration, did you actually buse this? My experience with it was that it didn't always correctly pick up new episodes, so I wasn't sure if it was actually being used by users.

I did liked it a lot until it got broken: see #280

@michaelarnauts michaelarnauts marked this pull request as ready for review December 16, 2021 16:18
@michaelarnauts michaelarnauts merged commit 148c11e into master Dec 19, 2021
@michaelarnauts michaelarnauts deleted the rework branch December 19, 2021 11:23
@michaelarnauts michaelarnauts added the bug Something isn't working label Dec 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants