Rework Kids zone #67
Merged
Rework Kids zone #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs a bit more work, I would rather have a single setting:
Rather than:
|
|
I also need to investigate if Kids zone has its own search functionality. And for the breadcrumbs (that are now implemented for Kids zone) it is not inherited to routes that don't have a kids-variant (like /program or /movie). Not sure if that is needed or not. |
|
Kids zone does have a different search endpoint. The results are filtered. |
dagwieers
force-pushed
the
kidszone
branch
2 times, most recently
from
659e542
to
42dd7a9
Compare
|
Ok, I fixed that as well. |
dagwieers
force-pushed
the
kidszone
branch
5 times, most recently
from
d41352f
to
124c1f1
Compare
dagwieers
force-pushed
the
kidszone
branch
2 times, most recently
from
25630a0
to
783ec93
Compare
This makes the Kids zone part of the routing.
|
Voor mij is dit klaar. Als er een beslissing is over de settings, dan kunnen we dat achteraf aanpassen. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the Kids zone part of the routing.