Dev #570
Merged
Dev #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add to Calendar exports a standard HTMLTagNameMap, which requires the component values to be any Node type. One of the the exported HTMLTagNameMap values, 'add-to-calendar-button', is currently of type AddToCalendarButtonType, which is a custom type definition that is not a subtype of Node. This change updates type definitions to appropriately assign HTMLElement (a type of Node) to the type definition for AddToCalendarButtonType.
Add `HTMLElement` to `AddToCalendarButtonType`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type(s) of changes
Description of the change
Checklist
npm run format).