Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix compatibility with Node 13 #86

Merged
merged 1 commit into from
Nov 22, 2019
Merged

Conversation

chrmoritz
Copy link
Contributor

@chrmoritz chrmoritz commented Nov 22, 2019

This PR should make lzma-native compatible with Node.js 13 by fixing compilation errors (due to recent V8 changes) like:

../src/index-parser.cpp:443:12: error: no matching member function for call to 'Set'
  exports->Set(NewString("IndexParser"), Nan::New<Function>(constructor));
  ~~~~~~~~~^~~
/Users/chrmoritz/Library/Caches/node-gyp/13.1.0/include/node/v8.h:3424:37: note: candidate function not viable: requires 3 arguments, but 2 were provided
  V8_WARN_UNUSED_RESULT Maybe<bool> Set(Local<Context> context,
                                    ^
/Users/chrmoritz/Library/Caches/node-gyp/13.1.0/include/node/v8.h:3427:37: note: candidate function not viable: requires 3 arguments, but 2 were provided
  V8_WARN_UNUSED_RESULT Maybe<bool> Set(Local<Context> context, uint32_t index,

This also adds Node.js 13 to the CI and removes the now EOL Node.js 11 from it.

.travis.yml Show resolved Hide resolved
@addaleax addaleax merged commit 6ebced9 into addaleax:master Nov 22, 2019
@chrmoritz chrmoritz deleted the node13 branch November 22, 2019 22:49
@addaleax
Copy link
Owner

Thanks, published in v4.0.6!

@addaleax addaleax added the build label Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants