Revert "stream: defer readable and flow when sync"

This reverts commit 563fff2 as it was causing failures in CITGM with `dicer`. Refs: nodejs#18515
addaleax · Feb 7, 2018 · 203e607 · 203e607
1 parent ee67dd0
commit 203e607
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 119 deletions.
diff --git a/lib/_stream_readable.js b/lib/_stream_readable.js
@@ -488,18 +488,11 @@ function onEofChunk(stream, state) {
   }
   state.ended = true;
 
-  if (state.sync && state.length) {
-    // if we are sync and have data in the buffer, wait until next tick
-    // to emit the data. otherwise we risk emitting data in the flow()
-    // the readable code triggers during a read() call
-    emitReadable(stream);
-  } else {
-    // emit 'readable' now to make sure it gets picked up.
-    state.needReadable = false;
-    if (!state.emittedReadable) {
-      state.emittedReadable = true;
-      emitReadable_(stream);
-    }
+  // emit 'readable' now to make sure it gets picked up.
+  state.needReadable = false;
+  if (!state.emittedReadable) {
+    state.emittedReadable = true;
+    emitReadable_(stream);
   }
 }
 

diff --git a/test/parallel/test-stream-pipe-flow.js b/test/parallel/test-stream-pipe-flow.js
diff --git a/test/parallel/test-stream-readable-pause-and-resume.js b/test/parallel/test-stream-readable-pause-and-resume.js