Skip to content
This repository has been archived by the owner on Apr 5, 2023. It is now read-only.

Several Depreciations in effect #155

Open
vip3rousmango opened this issue Mar 2, 2016 · 2 comments
Open

Several Depreciations in effect #155

vip3rousmango opened this issue Mar 2, 2016 · 2 comments

Comments

@vip3rousmango
Copy link

Trying to use ember-charts but with the latest Ember updates, a lot of the code used has deprecated items:

  1. @each is no longer used
  2. A property of <ligef-tool@view:-outlet::ember347> was modified inside the didInsertElement hook. You should never change properties on components, services or models during didInsertElement because it causes significant performance degradation. [deprecation id: ember-views.dispatching-modify-property]

With Ember 2.4 out, is an update planned to utilize the latest Ember features?
@mojason-81
Copy link

I'm running into the same issue using Ember 2.2.

@OakBehringer
Copy link

+1

shaunc added a commit to shaunc/ember-charts that referenced this issue Oct 14, 2016
@shaunc
don't modify attributes during render cycle
6b49c36 
Fixes (or at least improves) Addepar#155
Alternately, the update could happen before render cycle (e.g. using an observer).
@shaunc shaunc mentioned this issue Oct 14, 2016
Merged
metathinker pushed a commit that referenced this issue Nov 1, 2016
@shaunc @metathinker
don't modify attributes during render cycle (#189)
9bf777d 
Fixes (or at least improves) #155
Alternately, the update could happen before render cycle (e.g. using an observer).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vip3rousmango @OakBehringer @mojason-81