Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt DBSTATS for distinct Redis databases, fix #244 #255

Merged
merged 6 commits into from Feb 22, 2017

Conversation

davidbgk
Copy link
Contributor

No description provided.

@davidbgk davidbgk added this to the 1.0.0 milestone Feb 17, 2017
@yohanboniface
Copy link
Member

has_distinct_redis_db seems overkill to me.
What I'd do:

  • use DB for all keys expect document one
  • test if DOCUMENT_STORE is RedisStore
  • if yes, compute document key with ds._DB
  • if no, do nothing

Am I missing something?

@davidbgk
Copy link
Contributor Author

I don't think it's overkill (not sure if it's pertinent to put it in config vs. ds though) because if you want to have a consistent total and to handle the case of using the same Redis DB.

I was actually thinking about improving it a bit displaying the store (db) after the size. It would work easily with the size of the SQLite file for instance. Let's keep it as is and discuss on Monday :)

@davidbgk davidbgk force-pushed the shell-multiple-redis-db branch 2 times, most recently from c9b4a36 to 79b1627 Compare February 20, 2017 21:13
@davidbgk
Copy link
Contributor Author

After discussion, DBSTATS is too confusing and will be completely removed.

@davidbgk davidbgk merged commit 7a74545 into master Feb 22, 2017
@yohanboniface yohanboniface deleted the shell-multiple-redis-db branch February 28, 2017 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants