Skip to content

Commit

Permalink
Fix unclosed HTML element issue
Browse files Browse the repository at this point in the history
- Fix: Unclosed HTML element caused by improperly defined attribute `data-wishlist_id` of add to wishlist button. [GitHub Issue #348](#348)
  • Loading branch information
Asok17 committed May 18, 2023
1 parent e6471d9 commit 485a6ef
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions README.txt
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,7 @@ You can use this `[addonify_wishlist]` shortcode to display the wishlist table i
- Removed: Added to cart popup modal displayed when product is added to cart in wishlist page.
- Tweak: Popup modal now closes when clicked on modal overlay.
- Fix: Issue of product stock status not getting displaying in wishlist sidebar when a product is added into the wishlist. [GitHub Issue #344](https://github.com/addonify/addonify-wishlist/issues/344)
- Fix: Unclosed HTML element caused by improperly defined attribute `data-wishlist_id` of add to wishlist button. [GitHub Issue #348](https://github.com/addonify/addonify-wishlist/issues/348)

= 2.0.1 - 15 May, 2023 =

Expand Down
2 changes: 1 addition & 1 deletion public/class-addonify-wishlist-public.php
Original file line number Diff line number Diff line change
Expand Up @@ -572,7 +572,7 @@ public function render_add_to_wishlist_button_single() {

if (
addonify_wishlist_get_option( 'btn_position_on_single' ) === 'before_add_to_cart_form' ||
addonify_wishlist_get_option( 'btn_position_on_single' ) === 'adter_add_to_cart_form'
addonify_wishlist_get_option( 'btn_position_on_single' ) === 'after_add_to_cart_form'
) {
echo '</div>';
}
Expand Down
2 changes: 1 addition & 1 deletion public/templates/addonify-add-to-wishlist-button.php
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
$wishlist = '';
$button_label_preserved = '';
if ( isset( $parent_wishlist_id ) ) {
$wishlist = 'data-wishlist_id=' . $parent_wishlist_id;
$wishlist = 'data-wishlist_id="' . $parent_wishlist_id . '"';
} else {
$parent_wishlist_id = '';
}
Expand Down

0 comments on commit 485a6ef

Please sign in to comment.