Remove not needed dependencies from production code #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did not get rid of Still, removed 7 of 13 component deps :) |
| /** | ||
| * @covers Wikibase\Api\Service\RevisionSaver | ||
| */ | ||
| class RevisionSaverTest extends \PHPUnit_Framework_TestCase { |
There was a problem hiding this comment.
That's a lot of lines of test code to test the constructor which has no logic anyway. Also found some other very dubious tests, though those did not break, so I left them alone.
addshore
added a commit
that referenced
this pull request
Aug 25, 2015
Remove not needed dependencies from production code
addwiki-ci
pushed a commit
that referenced
this pull request
Feb 15, 2021
* Use ^2.7 of addwiki packages This isn't actually "needed" but seemingly things are having issues because of the switch from master to main branches. So let's see if this fixes things. * Try no composer cache * Keep master branch alias until next release * Remove no cache options, didn't do anything
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.