Skip to content

Commit

Permalink
Fix multi test
Browse files Browse the repository at this point in the history
This was not caught during the initial code review because there is a
bug in the test suite: see #67
  • Loading branch information
samccone committed Feb 17, 2015
1 parent 380ca1e commit b2374cc
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 3 deletions.
1 change: 1 addition & 0 deletions test/fixture/adaptive-final.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 16 additions & 0 deletions test/fixture/adaptive.html
@@ -0,0 +1,16 @@
<!doctype html>
<html class="no-js">
<head>
<meta charset="utf-8">
<title>critical css test</title>
<meta name="description" content="">
<meta name="viewport" content="width=device-width, initial-scale=1">
<link rel="stylesheet" href="styles/critical-adaptive.css"/>
</head>
<body>
<div id="revenge"></div>
<div id="of"></div>
<div id="guybrush"></div>
<div id="threepwood"></div>
</body>
</html>
6 changes: 3 additions & 3 deletions test/test.js
Expand Up @@ -54,11 +54,11 @@ describe('Module', function () {
});
});

it.skip('generates multi-dimension critical-path CSS successfully', function (done) {
var expected = fs.readFileSync('fixture/test-adaptive-final.css', 'utf8');
it('generates multi-dimension critical-path CSS successfully', function (done) {
var expected = fs.readFileSync('fixture/adaptive-final.css', 'utf8');
critical.generate({
base: 'fixture/',
src: 'test-adaptive.html',
src: 'adaptive.html',
dimensions: [{
width: 100,
height: 70
Expand Down

1 comment on commit b2374cc

@addyosmani
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for digging this up.

Please sign in to comment.