Allow external stylesheets passed as css option [#290]

addyosmani · Mar 19, 2018 · f0aba49 · f0aba49
1 parent 045096d
commit f0aba49
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 2 deletions.
diff --git a/lib/core.js b/lib/core.js
@@ -55,8 +55,11 @@ function appendStylesheets(opts) {
     return function (htmlfile) {
         // Consider opts.css and map to array if it isn't one
         if (opts.css) {
-            htmlfile.stylesheets = Array.isArray(opts.css) ? opts.css : [opts.css];
-            return htmlfile;
+            const css = Array.isArray(opts.css) ? opts.css : [opts.css];
+            return Bluebird.map(css, file.assertLocal).then(stylesheets => {
+                htmlfile.stylesheets = stylesheets;
+                return htmlfile;
+            });
         }
 
         // Oust extracts a list of your stylesheets

diff --git a/test/03-cli.js b/test/03-cli.js
@@ -173,6 +173,27 @@ describe('CLI', () => {
                 done();
             });
         });
+
+        it('should generate critical path css with external stylesheets passed as option', function (done) {
+            const cp = execFile('node', [
+                path.join(__dirname, '../', this.pkg.bin.critical),
+                `http://localhost:${serverport}`,
+                '--css', `http://localhost:${serverport}/styles/main.css`,
+                '--css', `http://localhost:${serverport}/styles/bootstrap.css`,
+                '--base', 'fixtures',
+                '--width', '1300',
+                '--height', '900'
+            ]);
+
+            const expected = fs.readFileSync(path.join(__dirname, 'expected/generate-default.css'), 'utf8');
+            cp.stdout.on('data', data => {
+                if (data instanceof Buffer) {
+                    data = data.toString('utf8');
+                }
+                assert.strictEqual(nn(data), nn(expected));
+                done();
+            });
+        });
     });
 
     describe('mocked', () => {