Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote URL doesn't work #211

Closed
davidhellmann opened this issue May 17, 2017 · 4 comments
Closed

Remote URL doesn't work #211

davidhellmann opened this issue May 17, 2017 · 4 comments

Comments

@davidhellmann
Copy link

Hey,

strange problem here. When I use the local url like website.dev all is fine.
When I use the remote url: website.com the task run and he generate all the temp files but not the css files.

Interesting part here is that the local tmp files are much longer as the remote tmp files.

Any Ideas?

@davidhellmann
Copy link
Author

Looks like some dependencies faults.
In old projects all fine but when I delete the node_modules folder and do a yarn install it's broken.

meeeeeeeeeh :D

@davidhellmann
Copy link
Author

const criticalDest = element.template + '_critical.min.css'

when I change the line above to this it works

const criticalDest = config.dist.markup + element.template + '_critical.min.css'

Looks like base doesn't work?

base: config.dist.markup,

@bezoerb
Copy link
Collaborator

bezoerb commented Jun 30, 2017

Hey @davidhellmann,
sorry for the late response. Can you provide some more insights on your problem?
I'm currently not quite sure how to help you as your last comment indicates that the issue might be in your setup and not in critical itself.

@bezoerb
Copy link
Collaborator

bezoerb commented Nov 30, 2018

Closing this due to lack of feedback.
Feel free to re-open if the error still exists.

Maybe try the latest version of critical first ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants