Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installing github master produces errors #49

Closed
propertunist opened this issue Nov 23, 2014 · 3 comments
Closed

installing github master produces errors #49

propertunist opened this issue Nov 23, 2014 · 3 comments

Comments

@propertunist
Copy link

following the advice in the issue regarding the toString errors.. i chose to install the github master version of critical using:

sudo npm install http://github.com/addyosmani/critical/tarball/master

towards the end of the terminal output, i saw more errors:

Received 12854K total.
Extracting tar contents (via spawned process)
Removing /mypath/critical-working/node_modules/critical/node_modules/penthouse/node_modules/phantomjs/lib/phantom
Copying extracted folder /mypath/critical-working/node_modules/critical/node_modules/penthouse/node_modules/phantomjs/phantomjs/phantomjs-1.9.8-linux-x86_64.tar.bz2-extract-1416739729376/phantomjs-1.9.8-linux-x86_64 -> /mypath/critical-working/node_modules/critical/node_modules/penthouse/node_modules/phantomjs/lib/phantom
Removing /mypath/critical-working/node_modules/critical/node_modules/penthouse/node_modules/phantomjs/phantomjs/phantomjs-1.9.8-linux-x86_64.tar.bz2-extract-1416739729376
Writing location.js file
Done. Phantomjs binary available at /mypath/critical-working/node_modules/critical/node_modules/penthouse/node_modules/phantomjs/lib/phantom/bin/phantomjs
npm ERR! Error: ENOENT, chmod '/mypath/critical-working/node_modules/critical/bin/critical'
npm ERR! If you need help, you may report this log at:
npm ERR!     <http://github.com/isaacs/npm/issues>
npm ERR! or email it to:
npm ERR!     <npm-@googlegroups.com>

npm ERR! System Linux 3.17.3-200.fc20.x86_64
npm ERR! command "node" "/bin/npm" "install" "http://github.com/addyosmani/critical/tarball/master"
npm ERR! cwd /mypath/critical-working
npm ERR! node -v v0.10.32
npm ERR! npm -v 1.3.6
npm ERR! path /mypath/critical-working/node_modules/critical/bin/critical
npm ERR! code ENOENT
npm ERR! errno 34
npm ERR! 
npm ERR! Additional logging details can be found in:
npm ERR!     /mypath/critical-working/npm-debug.log
npm ERR! not ok code 0

i looked into the debug log that is mentioned and did not see any info in there that was helpful to me in diagnosing the cause fo the errors.

bezoerb added a commit that referenced this issue Nov 24, 2014
@bezoerb
Copy link
Collaborator

bezoerb commented Nov 24, 2014

i updated the package.json to address this issue.
Can you please try again?

@bezoerb
Copy link
Collaborator

bezoerb commented Nov 24, 2014

you should not use sudo npm install to install local packages.

@propertunist
Copy link
Author

ok, i did originally not use sudo; however, i got permission errors and more errors that way.
i just ran the process again without sudo and all looks good this time, thanks.
from what i can see, the critical process did not produce any output against my test file, so there is still some issue of some form to resolve, though the download and install from github looks ok. thanks

@bezoerb bezoerb closed this as completed Nov 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants