Remove "preferGlobal": true, #114
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When installing with --save, "preferGlobal": true, should not be there. NPM will give a warning when using this.
|
I'm personally fine with the warning given this includes the CLI and we expect people to use it globally too. Happy to take @bezoerb's thoughts on this on board. |
|
I'm also totally fine with the warning as this should be installed globally when used on the command line. |
|
I agree with @bezoerb since the install instructions now state npm install --save critical without -g. |
|
Added global install instructions to the CLI section in the readme |
This was referenced May 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When installing with --save, "preferGlobal": true, should not be there. NPM will give a warning when using this.