-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support CleanCSS option #348
Conversation
Pull Request Test Coverage Report for Build 798
💛 - Coveralls |
* Add individual npm scripts. * Run xo against the whole codebase. * Lint.
* bump inline-critical & move noscript before closing body * Fix test files
@orthes: can you add cli support, too? And maybe it's more future proof to use the minify option so we're able to change the minifyer without changing the process. |
@bezoerb good feedback. Sure, that makes sense. I'll look into it. |
…l into feature-cleancss-option
I rembased the branch over master, unfied cleancss with minify option, added it to CLI and added a test |
That's not a rebase FYI. |
@XhmikosR i did rebase it over master. good ol |
You can clearly see the merge commits. That is not a rebase. |
I'll create a separate PR. I don't know why this one ended up in this state |
Since the project is using CleanCSS for minification, it makes sense to expose
cleancss
option that would get passed down tonew CleanCSS()
so if somebody chooses to go beyond CleanCSS' default options, they can do so.