Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support CleanCSS option #348

Closed
wants to merge 23 commits into from

Conversation

linkesch
Copy link

Since the project is using CleanCSS for minification, it makes sense to expose cleancss option that would get passed down to new CleanCSS() so if somebody chooses to go beyond CleanCSS' default options, they can do so.

@coveralls
Copy link

coveralls commented Dec 28, 2018

Pull Request Test Coverage Report for Build 798

  • 52 of 58 (89.66%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 89.437%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/config.js 10 12 83.33%
cli.js 4 8 50.0%
Totals Coverage Status
Change from base Build 770: -0.3%
Covered Lines: 590
Relevant Lines: 634

💛 - Coveralls

XhmikosR and others added 4 commits January 2, 2019 05:31
* Add individual npm scripts.

* Run xo against the whole codebase.

* Lint.
* bump inline-critical & move noscript before closing body

* Fix test files
@bezoerb
Copy link
Collaborator

bezoerb commented Jan 3, 2019

@orthes: can you add cli support, too?

And maybe it's more future proof to use the minify option so we're able to change the minifyer without changing the process.
true or options object = minify
false = no minify

@linkesch
Copy link
Author

linkesch commented Jan 4, 2019

@bezoerb good feedback. Sure, that makes sense. I'll look into it.

@linkesch
Copy link
Author

I rembased the branch over master, unfied cleancss with minify option, added it to CLI and added a test

@XhmikosR
Copy link
Collaborator

That's not a rebase FYI.

@linkesch
Copy link
Author

@XhmikosR i did rebase it over master. good ol git rebase master. it had some merge conflict in README which i resolved and for some reason it ended up looking like this. no idea why.

@XhmikosR
Copy link
Collaborator

You can clearly see the merge commits. That is not a rebase.

@linkesch
Copy link
Author

I'll create a separate PR. I don't know why this one ended up in this state

@linkesch linkesch closed this Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants