Use startsWith and endsWith when possible. #429
Conversation
XhmikosR
force-pushed
the
master-xmr-starts-ends
branch
from
10e654e
to
b19bb91
Compare
src/file.js
Outdated
| @@ -35,11 +35,15 @@ function normalizePath(str) { | |||
|
|
|||
| /** | |||
| * Check whether a resource is external or not | |||
| * @param {string} href Path | |||
| * @param {string|Vinyl} href Path | |||
There was a problem hiding this comment.
Not super familiar with jsdoc so please confirm this is right
There was a problem hiding this comment.
Shouldn't be ;)
Do you have a hint to start debugging where the Vinyl object is coming from?
There was a problem hiding this comment.
It happens in one of the vinyl tests. I'll revert this part so that we get more info.
src/file.js
Outdated
| * @returns {boolean} True if the path is remote | ||
| */ | ||
| function isRemote(href) { | ||
| return /(^\/\/)|(:\/\/)/.test(href) && !href.startsWith('file:'); | ||
| if (isVinyl(href)) { | ||
| return false; |
There was a problem hiding this comment.
I ended up adding a separate check for Vinyl. I'm not sure if the test is right; if it is then this check makes sense. If not, we should change the test @bezoerb
There was a problem hiding this comment.
The isRemote function shouldn't intentionally receive a vinyl object. Until we find out where the vinyl is coming from the test should be something like this:
if (isVinyl(href)) {
// Check custom attribute set in the vinylize function
return Boolean(href.remote)
}
XhmikosR
force-pushed
the
master-xmr-starts-ends
branch
from
b19bb91
to
0dabe1b
Compare
Makes the intention clearer.
XhmikosR
force-pushed
the
master-xmr-starts-ends
branch
from
0dabe1b
to
f8dafa2
Compare
XhmikosR
force-pushed
the
master-xmr-starts-ends
branch
from
1cc0d9e
to
f8a2687
Compare
|
@bezoerb please check now, you should see the failure |
Makes the intention clearer.
TODO: