Anchors #4
Merged
Anchors #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sponding hyperlinks to the table of contents.
… header (instead of 'name' attribute of separate 'a' tags)
addyosmani
added a commit
that referenced
this pull request
Jul 2, 2011
Updating book anchors of all the sections designations from the "name" attribute of an extra anchor tag to the "name" attribute of the section's header.
|
Excellent work!. Thanks jugglinmike :) |
|
My pleasure! I really appreciated the guide, and I'm happy to contribute (even if its just little nitpicky things). Maybe I can do something more substantial--I'll contact you with my thoughts on this soon! |
|
I look forward to hearing them!. I'm currently in the process of majorly refactoring the book content - my aim is to expand each pattern out into 2-3 actual pages of content vs the 3/4 of a page that's available on each at the moment. Much of this will probably not be committed for another few months, but any help in improving the book is always helpful :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought I would help you out with the section hyperlinks (as I had mentioned here http://addyosmani.com/blog/essentialjsdesignpatternsupdate1/#IDComment136636650 ).
I also updated all the sections designations from the "name" attribute of an extra anchor tag to the "name" attribute of the section's header. This modification is motivated by the conversation here: http://stackoverflow.com/questions/484719/html-anchors-with-name-or-id