-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unhandler error event #17
Comments
This should be fixed in master now. @igrigorik if you get a chance, could you give it another spin? $ npm install git://github.com/addyosmani/tmi -g |
works! QQ, trying it on nytimes:
Results are a bit confusing to me. First, it says the site is in the 60th quantile, but if so, why is +198KB for 75th percentile? That would imply that the site is 75th+ percentile. Also, minor nitpick: KB not kB (1024 vs 1000 :)). |
I can confirm that installing the package from master solves the problem. |
@igrigorik It looks like my calculations were a little askew there. I'm going to pull out support for the "You have more images than N" output to the next minor release so it can properly be fixed :) For now we'll have: $ tmi http://redrobin.com
Your image weight: 3.55 MB
Median mobile site image weight: 660 kB
Median desktop site image weight: 1.21 MB
On Mobile:
+3.49 MB compared to sites in the 25th percentile
+3.25 MB compared to sites in the 50th percentile
+2.73 MB compared to sites in the 75th percentile
On Desktop:
+3.41 MB compared to sites in the 25th percentile
+2.94 MB compared to sites in the 50th percentile
+2.14 MB compared to sites in the 75th percentile Is that okay? The KB -> kB formatting is due to a formatting module we're using, but I'll open an upstream issue with the author to address that :) |
Master works but NPM version still throws errors. Can you please re-publish? Thanks. |
Compiler told me that 'gpagespeed' module is missing. :| |
@ashumeow is this against master or the version on npm that you're seeing that exception thrown? I'm unable to repro locally but would like to confirm before pushing a new release. |
@addyosmani Yeah! You're right. |
With the latest version. Reported by @igrigorik and just verified as busted. Looking into it now.
The text was updated successfully, but these errors were encountered: