Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhandler error event #17

Closed
addyosmani opened this issue Nov 23, 2014 · 9 comments
Closed

Unhandler error event #17

addyosmani opened this issue Nov 23, 2014 · 9 comments
Labels

Comments

@addyosmani
Copy link
Owner

$ tmi http://redrobin.com

events.js:72
        throw er; // Unhandled 'error' event
              ^
Error: ENOENT, open '/usr/local/lib/node_modules/tmi/data/bigquery.csv'

With the latest version. Reported by @igrigorik and just verified as busted. Looking into it now.

@addyosmani addyosmani added the bug label Nov 23, 2014
@addyosmani
Copy link
Owner Author

This should be fixed in master now. @igrigorik if you get a chance, could you give it another spin?

$ npm install git://github.com/addyosmani/tmi -g

@igrigorik
Copy link

works!

QQ, trying it on nytimes:

On Mobile:
You have more image bytes than 60% of sites
+955 kB compared to sites in the 25th percentile
+712 kB compared to sites in the 50th percentile
+198 kB compared to sites in the 75th percentile

Results are a bit confusing to me. First, it says the site is in the 60th quantile, but if so, why is +198KB for 75th percentile? That would imply that the site is 75th+ percentile.

Also, minor nitpick: KB not kB (1024 vs 1000 :)).

@Tenzer
Copy link

Tenzer commented Nov 25, 2014

I can confirm that installing the package from master solves the problem.

@addyosmani
Copy link
Owner Author

@igrigorik It looks like my calculations were a little askew there. I'm going to pull out support for the "You have more images than N" output to the next minor release so it can properly be fixed :) For now we'll have:

$ tmi http://redrobin.com

Your image weight: 3.55 MB
Median mobile site image weight: 660 kB
Median desktop site image weight: 1.21 MB

On Mobile:
+3.49 MB compared to sites in the 25th percentile
+3.25 MB compared to sites in the 50th percentile
+2.73 MB compared to sites in the 75th percentile


On Desktop:
+3.41 MB compared to sites in the 25th percentile
+2.94 MB compared to sites in the 50th percentile
+2.14 MB compared to sites in the 75th percentile

Is that okay? The KB -> kB formatting is due to a formatting module we're using, but I'll open an upstream issue with the author to address that :)

@inadarei
Copy link

Master works but NPM version still throws errors. Can you please re-publish? Thanks.

@ashumeow
Copy link

Compiler told me that 'gpagespeed' module is missing. :|
I am also having issues with NPM though 👎

@addyosmani
Copy link
Owner Author

@ashumeow is this against master or the version on npm that you're seeing that exception thrown? I'm unable to repro locally but would like to confirm before pushing a new release.

@addyosmani
Copy link
Owner Author

After a fresh clone followed by npm install && npm link on a new machine:

screen shot 2014-11-28 at 20 44 52

@ashumeow
Copy link

@addyosmani Yeah! You're right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants