Fixes bug in Angular 9 where the gauge cannot be initialized #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes bug in gauge initialization process where the createChart function was called too early -- this change is backwards-compatible
|
Upon further investigation, it looks like there's still an error that appears in the console, though the component does load up (whereas before it didn't):
|
adedayo
approved these changes
Aug 7, 2020
There was a problem hiding this comment.
Thanks @Tzahi12345 for your patch. I have incorporated it.
I have also hopefully fixed the error above in the latest version 2.0.5 which should support Angular 9 and 10. Please let me know if you encounter any further issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #16. Basically, when trying to use this library on Angular 9, the component fails to initialize with the ngOnInit function as it's being called too early. Thankfully, there's an ngAfterViewInit function which fixes the issue with no apparent side effects. This is backwards-compatible as well.
See this SO post for more details.
Let me know if you have any questions regarding this PR! It's been tested on my end as well.