Show notifications for replied messages and handle oreo quick reply actions #175

spuday90 · 2021-03-07T04:47:47Z

closes #189

spuday90 · 2021-03-07T04:48:43Z

Hi @adeekshith Please check on your device, on mine somehow getting 2 replies.

adeekshith

Commented items and multiple replies needs to be fixed

adeekshith · 2021-03-07T06:53:49Z

app/src/main/java/com/parishod/watomatic/NotificationService.java

+                && remoteInputs.size() == 0 ) {
+                for(int x = 0; x < act.getRemoteInputs().length; x++) {
+                    RemoteInput remoteInput = act.getRemoteInputs()[x];
+                    if((remoteInput.getResultKey().toLowerCase().contains("reply")


Using English word "reply" may not work for other languages

Well actually i realised we dont need to check "reply" as remoteInput object is available only for reply action

… own reply

…only available for reply action

… permissions

…attach logs in mail

adeekshith · 2021-03-17T00:48:41Z

@spuday90

Can we separate debug logs sharing code (cherry-pick)? It has external storage permissions so we might want to avoid that for now.
What issues are we having with constrained layout?

spuday90 · 2021-03-17T01:49:46Z

@spuday90

* Can we separate debug logs sharing code (cherry-pick)? It has external storage permissions so we might want to avoid that for now.

* What issues are we having with constrained layout?

In the latest commit( 3b1a322 ) we have removed external storage permission and moved the logs write to internal storage
With constraint layout spacing was coming between main fragment content and dismiss notification settings, i think we can use biasing to fix that but felt linear layout is better and faster in that case so changed it

adeekshith · 2021-03-22T00:38:28Z

Also keeping the notification after reply only seems to be working for Whatsapp

spuday90 · 2021-03-22T02:32:26Z

Also keeping the notification after reply only seems to be working for Whatsapp

Oh!, have to debug which reply intent it is taking

adeekshith · 2021-03-22T02:39:30Z

Also keeping the notification after reply only seems to be working for Whatsapp

Oh!, have to debug which reply intent it is taking

I think manually replying to facebook via notification also dismisses it so not really app's fault

This reverts commit d300de0

This reverts commit 2f122c5

…ging app

adeekshith · 2021-04-02T04:06:16Z

@spuday90 conflicts

adeekshith · 2021-04-04T12:42:09Z

@spuday90 strings.xml and arrays.xml needs to be checked too. they replaced strings in main branch if not conflicting. I doubt if this branch is even compiling

adeekshith

Needs to be updated with latest "main" (merge/rebase)
Resolve conflicts with main
Fix strings.xml and arrays.xml if not already done
Remove logging to file code
Notification Setting
- Remove "Oreo+ only" if it works on previous ones also
- Move setting to "Settings activity"
- Change switch label to "Dismiss replied notifications"
- Remove help tip below the switch ("Turn On to dismiss...")

…ssue/134/autoreply-not-working-onfew-devices � Conflicts: � app/src/main/java/com/parishod/watomatic/NotificationService.java

adeekshith · 2021-04-05T22:31:33Z

I see this in the latest branch with Watomatic attribution enabled

adeekshith · 2021-04-05T22:45:45Z

Also clicking on Notification button is behaving like "Share" button. Is this happening only on mine?
Tried deleting local branch and pulled latest.

notification-btn-share.mp4

adeekshith · 2021-04-05T22:52:50Z

Watomatic notification icon too small. Let me know if it needs anything done from from me end.
Can we make it normal ("Alert" or similar) notification instead of Silent notification?
WhatsApp original notification is still present. Should we dismiss that?

spuday90 · 2021-04-06T02:16:37Z

Also clicking on Notification button is behaving like "Share" button. Is this happening only on mine?
Tried deleting local branch and pulled latest.
notification-btn-share.mp4

I completely removed share code in latest commit, so it should have crashed instead
If something was missed while removing that

spuday90 · 2021-04-06T02:18:38Z

* Watomatic notification icon too small. Let me know if it needs anything done from from me end.

* Can we make it normal ("Alert" or similar) notification instead of Silent notification?

* WhatsApp original notification is still present. Should we dismiss that?

For notification icon I have used the foreground one for now, we should generate actual notification icon, or we can use app icon, App icon will look fine in status bar but when status bar pulled down then icon will look greyed out.
2.Yes we can change silent notification to standard notification
3.Yes we should dismiss whatsapp notification, as for other apps it is anyhow dismissing so itll be consistent

adeekshith · 2021-04-06T14:16:39Z

Have you seen this happening?
I am getting multiple replies on this branch

…for single message

…://github.com/adeekshith/watomatic into issue/134/autoreply-not-working-onfew-devices

… than api 21

adeekshith · 2021-04-12T12:55:41Z

app/src/main/res/values/strings.xml

@@ -55,8 +55,17 @@
    <string name="watomatic_github_url" translatable="false">https://github.com/adeekshith/watomatic</string>
    <string name="watomatic_wato_message_url" translatable="false">https://www.reddit.com/r/watomatic/comments/lrkn7j/fellow_watos_share_your_creative_wato_message/</string>

+    <!-- Share debug logs -->
+    <string name="app_logs_file_name">WatomaticLogs.txt</string>


@spuday90 Mark all share debug logs as translatable="false"

adeekshith · 2021-04-12T12:57:12Z

app/src/main/res/values/strings.xml

    <!-- keys and app internal strings -->
    <string name="key_pref_app_language" translatable="false">pref_app_language</string>
+    <string name="pref_show_notification" translatable="false">pref_show_notification</string>


pref_show_notification -> pref_show_notification_replied_msg for value to future proof (but optional)

…tion_replied_msg

adeekshith · 2021-04-13T14:21:46Z

@spuday90 Approved this but I am still seeing these:

Notifications are silent
Clicking on notification is not opening any app

I remember you fixing it before but not sure. If that is not fixed, we can merge this PR and file an issue.

handle oreo quick reply actions

1d0f83f

spuday90 requested a review from adeekshith March 7, 2021 04:47

adeekshith requested changes Mar 7, 2021

View reviewed changes

spuday90 added 6 commits March 8, 2021 07:39

bugfix avoid duplicate reply if notification is just updated with our…

22ebc53

… own reply

add internal logging to debug reply failing on some devices

f636a62

refactor remove unnecessary remoteinput key check, as remoteInput is …

a9a7203

…only available for reply action

read/write logs from app directory which does not require any storage…

3b1a322

… permissions

add share logs option in settings

fffac0f

add share logs via email option, add content provider in manifest to …

510dfa6

…attach logs in mail

adeekshith mentioned this pull request Mar 10, 2021

Image message in group not recognized as group message sometimes #181

Closed

spuday90 and others added 3 commits March 16, 2021 09:47

add notification dismiss on auto reply switch

2f122c5

dismiss notification if based on user pref

d300de0

Merge branch 'main' into issue/134/autoreply-not-working-onfew-devices

35481e4

spuday90 added 5 commits March 24, 2021 07:47

resolve merge conflict of duplicate resources

26c6665

Revert "dismiss notification if based on user pref"

53562d8

This reverts commit d300de0

Revert "add notification dismiss on auto reply switch"

a93cac9

This reverts commit 2f122c5

add switch for show notifications in settings

28b9703

show notification for every replied messages one group per each messa…

3d62825

…ging app

spuday90 requested a review from adeekshith March 31, 2021 03:59

show notification if preference is enabled

d612d5e

adeekshith requested changes Apr 4, 2021

View reviewed changes

Merge branch 'main' of https://github.com/adeekshith/watomatic into i…

ed692ae

…ssue/134/autoreply-not-working-onfew-devices � Conflicts: � app/src/main/java/com/parishod/watomatic/NotificationService.java

refactor remove logging code

5ab4a21

spuday90 added 2 commits April 6, 2021 08:20

change notification priority to default

4c037b3

dismiss notification after reply

e26b538

spuday90 added 8 commits April 8, 2021 09:01

bugfix donot reply for auto-replied message, this prevents 2 replies …

500311f

…for single message

launch corresponding app when notification is clicked

d910733

bugfix flag should reset to false

54269dc

remove onNotificationRemoved callback

4f5f0fc

add logic to reset summary shown flag

000f1a2

add logic to reset notification summary shown flag

122e750

Merge branch 'issue/134/autoreply-not-working-onfew-devices' of https…

30ec2fd

…://github.com/adeekshith/watomatic into issue/134/autoreply-not-working-onfew-devices

append beta tag for show notification settings title for devices less…

b9c0feb

… than api 21

adeekshith reviewed Apr 12, 2021

View reviewed changes

Mark debug logs strings as non translatable

19732ef

adeekshith changed the title ~~handle oreo quick reply actions~~ Show notifications for replied messages and handle oreo quick reply actions Apr 13, 2021

Change settings key from pref_show_notification to pref_show_notifica…

4fb19aa

…tion_replied_msg

adeekshith approved these changes Apr 13, 2021

View reviewed changes

adeekshith merged commit db15a9e into main Apr 14, 2021

adeekshith deleted the issue/134/autoreply-not-working-onfew-devices branch April 14, 2021 01:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Show notifications for replied messages and handle oreo quick reply actions #175

Show notifications for replied messages and handle oreo quick reply actions #175

spuday90 commented Mar 7, 2021 •

edited by adeekshith

spuday90 commented Mar 7, 2021

adeekshith left a comment

adeekshith Mar 7, 2021

spuday90 Mar 8, 2021 •

edited

adeekshith commented Mar 17, 2021 •

edited

spuday90 commented Mar 17, 2021 •

edited

adeekshith commented Mar 22, 2021

spuday90 commented Mar 22, 2021

adeekshith commented Mar 22, 2021

adeekshith commented Apr 2, 2021

adeekshith commented Apr 4, 2021 •

edited

adeekshith left a comment •

edited

adeekshith commented Apr 5, 2021

adeekshith commented Apr 5, 2021

adeekshith commented Apr 5, 2021

spuday90 commented Apr 6, 2021

spuday90 commented Apr 6, 2021

adeekshith commented Apr 6, 2021

adeekshith Apr 12, 2021

adeekshith Apr 12, 2021

adeekshith commented Apr 13, 2021 •

edited

Show notifications for replied messages and handle oreo quick reply actions #175

Show notifications for replied messages and handle oreo quick reply actions #175

Conversation

spuday90 commented Mar 7, 2021 • edited by adeekshith

spuday90 commented Mar 7, 2021

adeekshith left a comment

Choose a reason for hiding this comment

adeekshith Mar 7, 2021

Choose a reason for hiding this comment

spuday90 Mar 8, 2021 • edited

Choose a reason for hiding this comment

adeekshith commented Mar 17, 2021 • edited

spuday90 commented Mar 17, 2021 • edited

adeekshith commented Mar 22, 2021

spuday90 commented Mar 22, 2021

adeekshith commented Mar 22, 2021

adeekshith commented Apr 2, 2021

adeekshith commented Apr 4, 2021 • edited

adeekshith left a comment • edited

Choose a reason for hiding this comment

adeekshith commented Apr 5, 2021

adeekshith commented Apr 5, 2021

adeekshith commented Apr 5, 2021

spuday90 commented Apr 6, 2021

spuday90 commented Apr 6, 2021

adeekshith commented Apr 6, 2021

adeekshith Apr 12, 2021

Choose a reason for hiding this comment

adeekshith Apr 12, 2021

Choose a reason for hiding this comment

adeekshith commented Apr 13, 2021 • edited

spuday90 commented Mar 7, 2021 •

edited by adeekshith

spuday90 Mar 8, 2021 •

edited

adeekshith commented Mar 17, 2021 •

edited

spuday90 commented Mar 17, 2021 •

edited

adeekshith commented Apr 4, 2021 •

edited

adeekshith left a comment •

edited

adeekshith commented Apr 13, 2021 •

edited