Issue/218/show whats new in release #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Working after restarting the VM but:
|
by filtering out intents for generic domain like deekshith.in which does not have any known supported apps
adeekshith
reviewed
Apr 18, 2021
There was a problem hiding this comment.
To be fixed:
- "Whats new" button does not go away after click
- Extra bracket after twitter URL:
Currently fixed this by putting a whitespace beside the URL on Github but should find a better way
Fixed in PR #223 :
- Make it work for Android 11+ without adding extra permissions possibly using this: Show what's new in the release #218 (comment)
Did not test but I am guessing present code will will not work as Android 11+ requires adding permissions to the manifest - Make it exclude possible browser intents
adeekshith
approved these changes
Apr 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #218