SXT: Use Tailwind setup #1330
Merged
SXT: Use Tailwind setup #1330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalsanger
requested review from
jaroslav-kubicek,
mrtnzlml and
tbergquist-godaddy
as code owners
| }); | ||
|
|
||
| it('skips empty media queries', () => { | ||
| it('skips empty media queries', async () => { |
There was a problem hiding this comment.
This is testing keyframes, but the it text says media queries
There was a problem hiding this comment.
Renamed to "skips unsupported at-rules"
michalsanger
force-pushed
the
sxt-plugins
branch
from
a646360
to
5dd8953
Compare
tbergquist-godaddy
approved these changes
Nov 15, 2020
This is a fundamental rework of SX Tailwind. Previously the styles definitions for SX were generated from a Tailwind CSS file, now it's generated from the same data the Tailwind itself is generated. It opens the way for a full support of customisation and simpler upgrade when a new version of Tailwind is released.
michalsanger
force-pushed
the
sxt-plugins
branch
from
5dd8953
to
0940cac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fundamental rework of SX Tailwind. Previously the styles definitions for SX were generated from a Tailwind CSS file, now it's generated from the same data the Tailwind itself is generated.
It opens the way for a full support of customisation and simpler upgrade when a new version of Tailwind is released.