Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure build with new Ruby versions #156

Merged
merged 2 commits into from Jun 3, 2015
Merged

Conversation

nicolasleger
Copy link
Contributor

No description provided.

@rhymes
Copy link
Contributor

rhymes commented Jun 3, 2015

I don't see the point in testing all the minor versions of a release unless there's a specific bug related to parse-ruby-client. Nor should it test for the HEAD version of the core language which is not even released yet. Don't you agree?

@nicolasleger
Copy link
Contributor Author

@rhymes You're totally right, I'm agree. I updated the patch to auto test on 2.x patched versions and avoid to write down the minor all time.

@rhymes
Copy link
Contributor

rhymes commented Jun 3, 2015

There's a bug in the syck library apparently, that's why this patch won't build. If you look at master they've danced around it: https://github.com/adelevie/parse-ruby-client/blob/master/test/helper.rb#L30

You should probably update your patch with the latest master

@nicolasleger
Copy link
Contributor Author

Thanks @rhymes, the patch for Syck didn't work for Ruby 2.2.0, I fixed it.

Indeed, by specifying 2.2 Travis should test on the most patched version (the 2.2.2) but currently Travis has not been updated to do so (see issue travis-ci/travis-ci#3885) so it tests on 2.2.0 which wasn't working properly.

@rhymes
Copy link
Contributor

rhymes commented Jun 3, 2015

Great!

xavdid added a commit that referenced this pull request Jun 3, 2015
Ensure build with new Ruby versions
@xavdid xavdid merged commit 96f95ca into adelevie:master Jun 3, 2015
@nicolasleger nicolasleger deleted the patch-2 branch June 3, 2015 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants