fix: AMI versioning is broken. (renovatebot#13740)

ademar59 · Jan 24, 2022 · 13f169f · 13f169f
1 parent 85d197e
commit 13f169f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/lib/versioning/aws-machine-image/index.spec.ts b/lib/versioning/aws-machine-image/index.spec.ts
@@ -43,9 +43,12 @@ describe('versioning/aws-machine-image/index', () => {
     });
   });
   describe('isGreaterThan(version1, version2)', () => {
-    it('should return false', () => {
-      expect(aws.isGreaterThan('ami-00', 'ami-99')).toBeFalse();
-      expect(aws.isGreaterThan('ami-99', 'ami-00')).toBeFalse();
+    it('should return true', () => {
+      // Since we can't compare AMI IDs directly, we consider any version
+      // greater than any other version so that updates will be generated.
+      // https://github.com/renovatebot/renovate/discussions/13739
+      expect(aws.isGreaterThan('ami-00', 'ami-99')).toBeTrue();
+      expect(aws.isGreaterThan('ami-99', 'ami-00')).toBeTrue();
     });
   });
 });
diff --git a/lib/versioning/aws-machine-image/index.ts b/lib/versioning/aws-machine-image/index.ts
@@ -24,7 +24,7 @@ class AwsMachineImageVersioningApi extends GenericVersioningApi {
   }
 
   protected override _compare(_version: string, _other: string): number {
-    return 0;
+    return 1;
   }
 }