feat: Add frequency type Six-monthly and biweekly. #3772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @EdwinBetanc0urt this change look fine but the dictionary changes must be with centralized ID's: https://github.com/adempiere/adempiere/pull/3772/files#diff-ed5abd0d1ed4b33411b10b6a121fa242c139b4afdb768548fe5bc5d5ce4c622bR6 Give me the pachout and I can generate it for you Best regards |
marcalwestf
added
14 Waiting for User Changes
|
@EdwinBetanc0urt, @yamelsenih can we move on here? |
added 2 commits
May 19, 2022 20:49
|
Greetings @marcalwestf @yamelsenih , the migration xml has been updated with the new centralized ids. |
marcalwestf
added
09 Pending Peer Review
and removed
14 Waiting for User Changes
|
@EdwinBetanc0urt thanks Edwin, proceeding to test right now. |
marcalwestf
approved these changes
May 23, 2022
There was a problem hiding this comment.
- XML loaded and applied
- Check Reference C_Commission Frequency: two entries added (Biweekly and Six-monthly), with translations
- Create two new Invoice Commission Definitions, one for Biweekly and another for Six-monthly and add Both GardenAdmin and GardenUser as Sales Representatives.
- Create four Commission Runs, twice referencing one of the new Commission Definitions
- Bi-weekly: set dates before and after 15th; Six-monthly: set dates before and after July 1st
- Run action prepare() for each Commission Run
- Check results: start and end dates correctly set on every run; correct invoice lines selected; correct commission amount calculated.
- Test was only run on Inovices (not run on Orders etc.) because it was not within the scope of the changes.
Test passed
EdwinBetanc0urt
deleted the
feature/#3771-frequency-type-six-monthly-biweekly
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #3771