fix(mocks): Fix JSON editor losing focus

ademuk · Dec 23, 2020 · e64cb5e · e64cb5e
1 parent 5104b32
commit e64cb5e
Showing 1 changed file with 5 additions and 7 deletions.
diff --git a/src/test/EditMockModal.tsx b/src/test/EditMockModal.tsx
@@ -1,4 +1,4 @@
-import { useEffect, useState } from "react";
+import { useState } from "react";
 import * as React from "react";
 // @ts-ignore
 import JSONInput from "react-json-editor-ajrm";
@@ -21,13 +21,11 @@ const EditMockModal: React.FC<EditStepProps> = ({
   onClose,
   onUpdateStep,
 }) => {
-  const [returnValue, setReturnValue] = useState({});
+  const [returnValue, setReturnValue] = useState(
+    step.definition.return ? step.definition.return : {}
+  );
   const [isValidJson, setIsValidJson] = useState(true);
 
-  useEffect(() => {
-    setReturnValue(step.definition.return ? step.definition.return : {});
-  }, [step.definition.return]);
-
   const handleReturnValueChange = ({
     error,
     jsObject,
@@ -62,7 +60,7 @@ const EditMockModal: React.FC<EditStepProps> = ({
           <div className="mt-2 flex">
             <JSONInput
               id="id"
-              placeholder={isValidJson ? returnValue : {}}
+              placeholder={step.definition.return}
               theme="light_mitsuketa_tribute"
               locale={locale}
               width="100%"