This repository has been archived by the owner on May 17, 2022. It is now read-only.
Add missing elements to RunStatus enum #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were some elements missing which could cause a `ValidationError` while accessing the `status`. I've copied the list from the Terraform API docs, in the same order as they appear there to make maintenance easy. https://www.terraform.io/docs/cloud/api/run.html
mvanholsteijn
approved these changes
Oct 5, 2020
There was a problem hiding this comment.
This is the list of states as defined by https://www.terraform.io/docs/cloud/api/run.html#run-states
alex-ikse
suggested changes
Oct 27, 2020
|
Hi @alex-ikse, I've listed the enum values in the order they appear in the TFC documentation deliberately. I believe this makes the list easier to maintain, should additional elements be added over time. |
alex-ikse
approved these changes
Oct 27, 2020
There was a problem hiding this comment.
Hi @james-emerton
It's a sensible point of view ;)
I accept your PR and will create a PR on the terraform documentation to sort the list :-D
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some elements missing which could cause a
ValidationErrorwhile accessing thestatus.I've copied the list from the Terraform API docs, in the same order as they appear there to make maintenance easy.
https://www.terraform.io/docs/cloud/api/run.html