Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[styles] - remove @include set-font-face(); inside components #1122

Closed
1 of 3 tasks
tiloyi opened this issue May 4, 2022 · 0 comments · Fixed by #1181
Closed
1 of 3 tasks

[styles] - remove @include set-font-face(); inside components #1122

tiloyi opened this issue May 4, 2022 · 0 comments · Fixed by #1181
Assignees
Labels
BREAKING CHANGE This pull request create breaking change @next Anything related to the next major version

Comments

@tiloyi
Copy link
Contributor

tiloyi commented May 4, 2022

🚀 Pattern enhancement proposal

What kind of enhancement are you proposing ?

  • On sketch file
  • On Documentation
  • On source code

Description

For performance reasons and in anticipation of the Design System handling multiple themes, all calls to @include set-font-face(); within components should be removed.

Details

The set-font-face() mixin allows to set the font-family property together with the font-weight property, within a CSS rule.

Currently, this mixin is called on almost all components; this causes performance problems for projects that use a large number of Mozaic components because the same rules are repeated many times.

In addition, as part of the evolution of the Design System and its availability to other brands of the ADEO group, it should be possible to let the users of these brands set their font as they wish.

For all these reasons, we have decided to remove the call to this mixin in our components, and recommend users to use this mixin on their side in a generic or reset stylesheet.

In case they don't have a style sheet or a reset sheet, they can use the one provided in Mozaic & which includes this mixin in a unique way:
=>https://github.com/adeo/mozaic-design-system/blob/master/packages/styles/generic/_g.reset.scss

@tiloyi tiloyi added this to the Road to @mozaic-ds v2 milestone May 4, 2022
@tiloyi tiloyi changed the title [@mozaic-ds/styles] - remove @include set-font-face(); inside components [styles] - remove @include set-font-face(); inside components May 4, 2022
@tiloyi tiloyi added the @next Anything related to the next major version label May 4, 2022
@tiloyi tiloyi self-assigned this Jun 17, 2022
@tiloyi tiloyi added the BREAKING CHANGE This pull request create breaking change label Jun 17, 2022
tiloyi added a commit that referenced this issue Sep 26, 2022
@tiloyi tiloyi closed this as completed Sep 28, 2022
tiloyi added a commit that referenced this issue Dec 9, 2022
tiloyi added a commit that referenced this issue Dec 19, 2022
tiloyi added a commit that referenced this issue Dec 19, 2022
tiloyi added a commit that referenced this issue Feb 3, 2023
tiloyi added a commit that referenced this issue Mar 21, 2023
tiloyi added a commit that referenced this issue Mar 26, 2023
tiloyi added a commit that referenced this issue Mar 26, 2023
tiloyi added a commit that referenced this issue May 9, 2023
tiloyi added a commit that referenced this issue May 9, 2023
tiloyi added a commit that referenced this issue Jun 1, 2023
tiloyi added a commit that referenced this issue Jun 2, 2023
tiloyi added a commit that referenced this issue Jun 2, 2023
tiloyi added a commit that referenced this issue Jun 14, 2023
tiloyi added a commit that referenced this issue Jun 15, 2023
tiloyi added a commit that referenced this issue Jun 21, 2023
tiloyi added a commit that referenced this issue Jun 21, 2023
tiloyi added a commit that referenced this issue Jun 21, 2023
tiloyi added a commit that referenced this issue Jun 21, 2023
tiloyi added a commit that referenced this issue Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING CHANGE This pull request create breaking change @next Anything related to the next major version
Projects
None yet
1 participant