-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[styles] - remove @include set-font-face();
inside components
#1122
Labels
BREAKING CHANGE
This pull request create breaking change
@next
Anything related to the next major version
Milestone
Comments
@include set-font-face();
inside components@include set-font-face();
inside components
tiloyi
added a commit
that referenced
this issue
Jun 17, 2022
4 tasks
4 tasks
4 tasks
4 tasks
tiloyi
added a commit
that referenced
this issue
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
BREAKING CHANGE
This pull request create breaking change
@next
Anything related to the next major version
🚀 Pattern enhancement proposal
What kind of enhancement are you proposing ?
Description
For performance reasons and in anticipation of the Design System handling multiple themes, all calls to
@include set-font-face();
within components should be removed.Details
The
set-font-face()
mixin allows to set thefont-family
property together with thefont-weight
property, within a CSS rule.Currently, this mixin is called on almost all components; this causes performance problems for projects that use a large number of Mozaic components because the same rules are repeated many times.
In addition, as part of the evolution of the Design System and its availability to other brands of the ADEO group, it should be possible to let the users of these brands set their font as they wish.
For all these reasons, we have decided to remove the call to this mixin in our components, and recommend users to use this mixin on their side in a generic or reset stylesheet.
In case they don't have a style sheet or a reset sheet, they can use the one provided in Mozaic & which includes this mixin in a unique way:
=>https://github.com/adeo/mozaic-design-system/blob/master/packages/styles/generic/_g.reset.scss
The text was updated successfully, but these errors were encountered: