-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(patterns/toggle): fix :disabled:checked state #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiloyi
added
🧯 fix
A bug fix
scope:component
Anything related to a component
skill:dev
labels
Dec 9, 2019
tiloyi
force-pushed
the
fix-MZC-257-toogles
branch
from
December 9, 2019 14:04
dad9d08
to
8f3cf8e
Compare
tiloyi
changed the title
fix(patterns/toggle): update :disabled:checked state
fix(patterns/toggle): fix :disabled:checked state
Dec 9, 2019
caqueste
approved these changes
Dec 10, 2019
tiloyi
force-pushed
the
fix-MZC-257-toogles
branch
from
December 10, 2019 11:31
8f3cf8e
to
1aac602
Compare
gael-boyenval
approved these changes
Dec 11, 2019
gael-boyenval
suggested changes
Dec 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resolve conflict in designer kits and rebase
tiloyi
force-pushed
the
fix-MZC-257-toogles
branch
from
December 11, 2019 14:52
1aac602
to
187e88f
Compare
@gael-boyenval it's ok for the rebase. |
…s case and BEM structure (#454)
…ystem into fix-MZC-257-toogles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have read the contributing guidelines
Does this PR introduce a breaking change?
read What is a breaking change ?
Describe the changes
Update the CSS for the state :disabled:checked of the toggles.
Github issue number or Jira issue URL: MZC-257
Other informations