-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(foundations/color): grammar review #658
Conversation
…into feat-clean-doc-1
|
||
Used to inform abouts risks or threats. It teel the user to be carefull about something. | ||
Inform the user about risks or threats. It teel the user to be careful about something. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It tells
|
||
<Swatch id="warning" /> | ||
|
||
## Danger | ||
|
||
Used to inform user of an error, or that some operation whent wrong. | ||
Inform the user of an error, or that some operation went wrong. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Informs the user of an error or that some operation went wrong.
@@ -92,13 +92,13 @@ Use the [info]() swatch to highlight anything related to informational feedback | |||
|
|||
## Secondary Green | |||
|
|||
Secondary Green is for success. In LEROY MERLIN case, it is exacltly the case as the primary-01. But other brands or BU should be able to change that. | |||
Secondary Green is for success. In LEROY MERLIN case, it is exactly the case as the primary-01. But other brands or BU should be able to change that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In LEROY MERLIN case, this color is exactly the case as primary-01
but other brands or BU should be able to change that.
|
||
> HSLA is a way to define colors based on three properties : **Hue**, **Saturation**, **Light** and **Alpha**. We decided to use this standard to have more consistency between colors. It is also easier to relate colors to each other when they are based on HSLA. | ||
> HSLA is a way to define colors based on three properties: **Hue**, **Saturation**, **Light**, and **Alpha**. We decided to use this standard to have more consistency between colors. It is also easier to relate colors to each other when they are based on HSLA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can delete this part
@caqueste, we're not making rockets fly right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nherwegh @mohamedMok I think this part can save us from the covid..
Let's delete it haha
|
||
This system allows the team to have every tint it needs to design every situation. It answers typography problems, illustration needs and it also allows to contrast with deep background colors. Here is an example showing how it works based on our Primary-01 Secondary-Purple colors. | ||
This system allows the team to have every tint it needs to design every situation. It answers typography problems, illustration needs and it also allows us to contrast with deep background colors. Here is an example showing how it works based on our Primary-01 Secondary-Purple colors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete this also? @caqueste
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nherwegh Yes, we can delete this part too, I think the visuals are enough explicit.
status: | ||
sketch: 'stable' | ||
scss: 'stable' | ||
--- | ||
|
||
> Mozaic offers an adaptive and a scalable color system. These colors have been defined using [HSLA](/Foundations/Colors/#anatomy) color swatches. The color palette has been divided in four categories : **Primary colors**, **Secondary colors** ,**Greys** and **Status colors**. | ||
> Mozaic offers an adaptive and scalable color system. These colors have been defined using [HSLA](/Foundations/Colors/#anatomy) color swatches. The color palette has been divided in four categories: **Primary colors**, **Secondary colors**,**Greys** and **Status colors**. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mozaic offers an adaptive and scalable color system. The color palette has been divided in four categories: Primary colors, Secondary colors,Greys and Status colors.
@caqueste agree with that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nherwegh I love it!
|
||
<Swatch id="warning" /> | ||
|
||
## Danger | ||
|
||
Used to inform user of an error, or that some operation whent wrong. | ||
Inform the user of an error or that some operation went wrong. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This color informs the user of an error or that some operation went wrong.
(I think it's better for the global understanding 😉)
…into docs-foundation-color
@@ -1,48 +1,48 @@ | |||
--- | |||
title: 'Colors' | |||
order: 3 | |||
description: 'Mozaic offers an adaptive and a scalable color system. The color palette has been divided in three categories: primary colors, secondary colors and greys.' | |||
description: 'Mozaic offers an adaptive and scalable color system. The color palette has been divided into three categories: primary colors, secondary colors, and greys.' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mozaic offers an adaptive and scalable color system. The color palette has been divided into three categories: primary colors, secondary colors, and greys.
Mozaic offers an adaptive and scalable color system. The color palette has been divided into four categories: Primary colors, Secondary colors, Greys and Status colors.
status: | ||
sketch: 'stable' | ||
scss: 'stable' | ||
--- | ||
|
||
> Mozaic offers an adaptive and a scalable color system. These colors have been defined using [HSLA](/Foundations/Colors/#anatomy) color swatches. The color palette has been divided in four categories : **Primary colors**, **Secondary colors** ,**Greys** and **Status colors**. | ||
> Mozaic offers an adaptive and scalable color system. The color palette has been divided in four categories: **Primary colors**, **Secondary colors**,**Greys** and **Status colors**. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in into
I have read the contributing guidelines
Does this PR introduce a breaking change?
Describe the changes
GitHub issue number or Jira issue URL: N/A
Other information