Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pattern/cards): add card pattern design part #724

Merged
merged 20 commits into from
Mar 17, 2021
Merged

feat(pattern/cards): add card pattern design part #724

merged 20 commits into from
Mar 17, 2021

Conversation

nherwegh
Copy link
Contributor

I have read the contributing guidelines

  • Yes
  • No

Does this PR introduce a breaking change?

  • Yes
  • No

Describe the changes

GitHub issue number or Jira issue URL: N/A

Other information

@nherwegh nherwegh added scope:component Anything related to a component 🚧 [WIP] Work in progress ⚡ design Anything related to design skills labels Jan 20, 2021
@nherwegh nherwegh self-assigned this Jan 20, 2021
@ghost ghost temporarily deployed to staging January 20, 2021 16:11 Inactive
@mohamedMok
Copy link
Contributor

Usage feedbacks:

  • You may want to add a section about the card behavior - How it handles long description (expand or scroll)?
  • Without any action within the card - Does the card become actionable?

@nherwegh nherwegh removed the 🚧 [WIP] Work in progress label Jan 25, 2021
@nherwegh nherwegh changed the title [WIP] feat(pattern/cards): add card pattern design part feat(pattern/cards): add card pattern design part Jan 26, 2021
tiloyi
tiloyi reviewed Jan 26, 2021
View reviewed changes
src/docs/Components/Cards/index.mdx Outdated Show resolved Hide resolved
src/docs/Components/Cards/index.mdx Outdated Show resolved Hide resolved
src/docs/Components/Cards/index.mdx Show resolved Hide resolved
@ghost ghost temporarily deployed to staging January 28, 2021 16:02 Inactive
@ghost ghost temporarily deployed to staging February 1, 2021 11:36 Inactive
@ghost ghost temporarily deployed to staging February 1, 2021 11:47 Inactive
nherwegh
nherwegh commented Feb 2, 2021
View reviewed changes
Copy link
Contributor Author

@nherwegh nherwegh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some typos here and there

src/docs/Components/Cards/index.mdx Outdated Show resolved Hide resolved
src/docs/Components/Cards/index.mdx Outdated Show resolved Hide resolved
src/docs/Components/Cards/index.mdx Outdated Show resolved Hide resolved
src/docs/Components/Cards/index.mdx Outdated Show resolved Hide resolved
@ghost ghost temporarily deployed to staging February 2, 2021 11:00 Inactive
@ghost ghost temporarily deployed to staging March 9, 2021 16:22 Inactive
@ghost ghost temporarily deployed to staging March 11, 2021 09:13 Inactive
@ghost ghost temporarily deployed to staging March 11, 2021 09:25 Inactive
@ghost ghost temporarily deployed to staging March 11, 2021 09:46 Inactive
@tiloyi tiloyi force-pushed the feat-cards--design branch 2 times, most recently from 31f19b6 to 9acde60 Compare March 11, 2021 09:54
@tiloyi tiloyi requested a review from mohamedMok March 11, 2021 09:58
@tiloyi tiloyi self-assigned this Mar 11, 2021
@ghost ghost temporarily deployed to staging March 11, 2021 10:05 Inactive
@ghost ghost temporarily deployed to staging March 11, 2021 10:19 Inactive
@ghost ghost temporarily deployed to staging March 17, 2021 08:29 Inactive
@tiloyi tiloyi requested a review from caqueste March 17, 2021 08:33
@ghost ghost temporarily deployed to staging March 17, 2021 08:52 Inactive
@ghost ghost temporarily deployed to staging March 17, 2021 09:15 Inactive
@tiloyi tiloyi merged commit 5291072 into master Mar 17, 2021
@tiloyi tiloyi deleted the feat-cards--design branch March 17, 2021 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiloyi tiloyi tiloyi left review comments

@mohamedMok mohamedMok mohamedMok approved these changes

@caqueste caqueste caqueste approved these changes

Assignees

@tiloyi tiloyi

@nherwegh nherwegh

Labels
scope:component Anything related to a component ⚡ design Anything related to design skills
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nherwegh @mohamedMok @tiloyi @caqueste