Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complex (bad) relative import of token SCSS file #775

Closed
1 of 3 tasks
pinguet62 opened this issue Mar 26, 2021 · 3 comments · Fixed by #1249
Closed
1 of 3 tasks

Complex (bad) relative import of token SCSS file #775

pinguet62 opened this issue Mar 26, 2021 · 3 comments · Fixed by #1249
Assignees
Labels
BREAKING CHANGE This pull request create breaking change @next Anything related to the next major version

Comments

@pinguet62
Copy link
Contributor

🐞 Pattern bug report

Where did you experience this bug ?

  • On sketch file
  • On Documentation
  • On source code

Is this a regression?

No.

Description

When I @import "@mozaic-ds/styles/settings-tools/all-settings"; I have an error because the (1st line) @import '_tokens.scss'; doesn't work...
This require to configure includePaths of style loader in my project:

  • Vue.js : in sass entry of vue.config.js
  • Angular: stylePreprocessorOptions entry of angular.json
  • worse: use a plugin with side effects...

Do you have any solution to avoid this configuration?
For example merge @mozaic-ds/styles with @mozaic-ds/tokens, or in _all-settings.scss use @import '@mozaic-ds/tokens/build/scss/tokens';, ...

🔬 Steps to reproduce the issue

vue create -d hello-world
cd hello-world
npm install @mozaic-ds/styles
npm run serve

set <style> in App.vue file

<style lang="scss">
@import "~@mozaic-ds/styles/settings-tools/all-settings";
</style>

📷 Screenshot (optional - it might be a gif) or Sketch file (if existing)

🔥 Exception or Error





🌍 Your Environment

Styleguide Version:





Anything else relevant?

@tiloyi tiloyi self-assigned this Jul 6, 2021
@tiloyi tiloyi added the @next Anything related to the next major version label Feb 28, 2022
@tiloyi tiloyi added this to the Road to @mozaic-ds V2 milestone Apr 26, 2022
@tiloyi tiloyi added the BREAKING CHANGE This pull request create breaking change label May 4, 2022
@ghost
Copy link

ghost commented May 6, 2022

Any news of this issue ? I have the same problem. How can I fix it ? Thanks

@Maxim-Ishenko
Copy link

I've the same problem with react. Could you share some info about it?

@pinguet62
Copy link
Contributor Author

Not really solved, is it?

tiloyi added a commit that referenced this issue Dec 9, 2022
tiloyi added a commit that referenced this issue Dec 19, 2022
tiloyi added a commit that referenced this issue Dec 19, 2022
tiloyi added a commit that referenced this issue Feb 3, 2023
tiloyi added a commit that referenced this issue Mar 21, 2023
tiloyi added a commit that referenced this issue Mar 26, 2023
tiloyi added a commit that referenced this issue Mar 26, 2023
tiloyi added a commit that referenced this issue May 9, 2023
tiloyi added a commit that referenced this issue May 9, 2023
tiloyi added a commit that referenced this issue Jun 1, 2023
tiloyi added a commit that referenced this issue Jun 2, 2023
tiloyi added a commit that referenced this issue Jun 2, 2023
tiloyi added a commit that referenced this issue Jun 14, 2023
tiloyi added a commit that referenced this issue Jun 15, 2023
tiloyi added a commit that referenced this issue Jun 21, 2023
tiloyi added a commit that referenced this issue Jun 21, 2023
tiloyi added a commit that referenced this issue Jun 21, 2023
tiloyi added a commit that referenced this issue Jun 21, 2023
tiloyi added a commit that referenced this issue Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING CHANGE This pull request create breaking change @next Anything related to the next major version
Projects
None yet
4 participants