Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(component/loader): unify the loader text colour & the spinner colour #1068

Merged
merged 2 commits into from Mar 23, 2022
Merged

fix(component/loader): unify the loader text colour & the spinner colour #1068

merged 2 commits into from Mar 23, 2022

Conversation

tiloyi
Copy link
Contributor

@tiloyi tiloyi commented Mar 21, 2022 •
edited

I have read the contributing guidelines

  • Yes
  • No

Does this PR introduce a breaking change?

  • Yes
  • No

Describe the changes

Unify the colour of the loader text with the colour of the spinner

@tiloyi tiloyi requested a review from mohamedMok March 21, 2022 09:26
@tiloyi tiloyi self-assigned this Mar 21, 2022
mohamedMok
mohamedMok approved these changes Mar 23, 2022
View reviewed changes
Copy link
Contributor

@mohamedMok mohamedMok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice trick currentColor @tiloyi 💯

@mohamedMok mohamedMok merged commit 10c1ccb into master Mar 23, 2022
@mohamedMok mohamedMok deleted the fix-loader-color branch March 23, 2022 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohamedMok mohamedMok mohamedMok approved these changes

Assignees

@tiloyi tiloyi

Labels
🧯 fix A bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tiloyi @mohamedMok