Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thumbnails for recent searchs #19

Closed
adeora7 opened this issue Oct 6, 2017 · 2 comments
Closed

Thumbnails for recent searchs #19

adeora7 opened this issue Oct 6, 2017 · 2 comments
Assignees
@lmcjt37
Labels
enhancement hacktoberfest intermediate

Comments

@adeora7
Copy link
Owner

adeora7 commented Oct 6, 2017

Thumbnails can be saved for at least 5 recently searched users for quick search. One option for design can be round images/handles right above the search box.
@lmcjt37
Copy link
Collaborator

lmcjt37 commented Oct 6, 2017 •
edited
Loading

I could look into this and add the ability to store the data alongside it?

update: A thought on storing PR item data, is that the data could be out of date so would make sense to only store the username and thumbnails. What do you think?

@adeora7
Copy link
Owner Author

adeora7 commented Oct 7, 2017

Yes, even I thought about it. Lets save user handle only in the thumbnail. @lmcjt37 And sure, please handle this also if you want to :)

@lmcjt37 lmcjt37 mentioned this issue Oct 7, 2017
Merged
adeora7 added a commit that referenced this issue Oct 7, 2017
@adeora7
Merge pull request #21 from lmcjt37/thumbnails-and-recent-searches
6cfb2f3 
refactored code to store thumbnails and most recent users - #19
@adeora7 adeora7 closed this as completed Oct 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lmcjt37 lmcjt37

Labels
enhancement hacktoberfest intermediate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lmcjt37 @adeora7