Circleci/2.0 #223
Merged
Circleci/2.0 #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update project pipeline to CircleCI 2.0
This required a new CircleCI configuration file and some changes to the tests inheriting from AbstractWebTestTemplate, as CircleCI runs these tests atomic, not in batch (resulting in some fuzzy cross-test dependencies).
I also followed the boy scouts rule: "Always leave a place cleaner than you found it" and moved the mocking parts to the parent template class AbstractWebTestTemplate.
Now, the tests look much cleaner and do not concern themselves with mocking.
Right now, the mock data is loaded in Java code. It might be possible to move this data to xml configuration files, cleaning up the AbstractWebTestTemplate class.
This can be done in a future Pull Request.