fixup! Remove controller error logs

adevinta · Mar 26, 2024 · ee05d53 · ee05d53
1 parent 3266430
commit ee05d53
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/pkg/controllers/pod_test.go b/pkg/controllers/pod_test.go
@@ -825,8 +825,12 @@ func TestReconcileShouldRequeuedWhenNodeSpecGetError(t *testing.T) {
 
 	result, err := reconciler.Reconcile(context.Background(), reconcile.Request{NamespacedName: types.NamespacedName{Name: "test-pod-1", Namespace: "ns"}})
 	assert.Error(t, err)
-	assert.True(t, result.Requeue)
-
+	assert.Empty(t, result)
+	if termError, ok := err.(interface{ Is(err error) bool }); ok {
+		// Reconcile retries any error but terminal errors.
+		// Ensure this error is not terminal.
+		assert.False(t, termError.Is(reconcile.TerminalError(nil)))
+	}
 }
 
 func TestReconcileWhenPodBelongsToStatefulSetIsAlwaysChecked(t *testing.T) {