fix(pkg/arch): Do not ignore images without OS #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Background ===== Noe goes through all the images available and skips the ones that do not match the host Operating System, so we don't end up running a container with a different OS than the host. Problem ===== In some cases, the images come with the `architecture` key but not the `OS` in the manifest file. This causes the `Noe` to skip the image, and to throw an error: ``` Error from server (could not find a common image architecture across all containers): admission webhook "noe.noe.svc" denied the request: could not find a common image architecture across all containers ``` Problem reproduction ===== To reproduce the problem, you run the following command: ``` kubectl run curl-wlapi --image=radial/busyboxplus:curl -i --tty --rm ``` This returns a message: ``` Error from server (could not find a common image architecture across all containers): admission webhook "noe.noe.svc" denied the request: could not find a common image architecture across all containers ``` Goal ===== To only compare the Manifest image and host OS when the image has the the field. If the field is not present, then we should not compare them. Change-Id: Iacbb8082cd9c03088c9974876db9df5ee9975422
miguelbernadi
approved these changes
May 15, 2023
carlosrejano
approved these changes
May 15, 2023
chrsalx
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Noe goes through all the images available and skips the ones that do not match the host Operating System, so we don't end up running a container with a different OS than the host.
Problem
In some cases, the images come with the
architecturekey but not theOSin the manifest file. This causes theNoeto skip the image, and to throw an error:Problem reproduction
To reproduce the problem, you run the following command:
This returns a message:
Goal
To only compare the Manifest image and host OS when the image has the the field. If the field is not present, then we should not compare them.
Change-Id: Iacbb8082cd9c03088c9974876db9df5ee9975422