fix(dropdown): prevent radix focus trap to disable scroll inside dropdown #1857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acd02
reviewed
Jan 29, 2024
acd02
changed the title
Powerplex
force-pushed
the
debug-dropdown-dialog
branch
from
66191e0
to
e97aa36
Compare
Powerplex
force-pushed
the
debug-dropdown-dialog
branch
from
e97aa36
to
6e2dd39
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1857 +/- ##
=======================================
Coverage 98.05% 98.05%
=======================================
Files 709 709
Lines 5042 5042
Branches 1836 1836
=======================================
Hits 4944 4944
Misses 98 98 ☔ View full report in Codecov by Sentry. |
acd02
approved these changes
Jan 30, 2024
soykje
approved these changes
Jan 30, 2024
Powerplex
force-pushed
the
debug-dropdown-dialog
branch
from
6e2dd39
to
73d2e49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TYPE(SCOPE): TITLE
TASK: #1838
Description, Motivation and Context
Please check this issue radix-ui/primitives#1159
For now the best I can do is prevent Radix from setting
pointerEvents: "none"in the styleattributesofDropdown.Items(which is merged withPopover.ContentthroughasChild)Types of changes