fix(combobox): make combobox popover non clickable while closed #2322
+752
−259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Powerplex
force-pushed
the
bump-radix-popover
branch
from
6d73855
to
b6e7382
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2322 +/- ##
=======================================
Coverage 96.47% 96.47%
=======================================
Files 493 493
Lines 4139 4141 +2
Branches 1340 1305 -35
=======================================
+ Hits 3993 3995 +2
Misses 144 144
Partials 2 2 ☔ View full report in Codecov by Sentry. |
acd02
reviewed
Jul 25, 2024
Powerplex
force-pushed
the
bump-radix-popover
branch
from
b6e7382
to
6f8e7f5
Compare
Powerplex
force-pushed
the
bump-radix-popover
branch
from
6f8e7f5
to
b1a8d54
Compare
acd02
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description, Motivation and Context
Bump
@radix-ui/react-popoverand fixes regression in Combobox.Added e2e tests for similar use-case (combining Dialog with Dropdown)
Types of changes