Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listen to custom port #27

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

filewalkwithme
Copy link
Contributor

This PR introduces a new configuration field api.port, so users can run the Vulnerability DB API in a port different than :8080

The default value will be 8080, so existing toml files are kept valid.

Copy link
Contributor

@jesusfcr jesusfcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the port should be added also to the config.toml, README.md, and implement the default in the run.sh.

@filewalkwithme
Copy link
Contributor Author

Hi @jesusfcr, thanks for having a look into this! 😄

I have added the port to the config.toml, README.md and local.env files.

There was no need to add to run.toml, since it's auto generate based on the contents of config.toml plus local.env, the port will be added to file after we run envsubst on it. Let me know if it does not work like that.

@jesusfcr
Copy link
Contributor

Hi @jesusfcr, thanks for having a look into this! 😄

I have added the port to the config.toml, README.md and local.env files.

There was no need to add to run.toml, since it's auto generate based on the contents of config.toml plus local.env, the port will be added to file after we run envsubst on it. Let me know if it does not work like that.

Hi, is in config.toml where you have to use the variable.

@filewalkwithme
Copy link
Contributor Author

@jesusfcr done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants