Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement signed keys #24

Open
adevore opened this issue Jul 24, 2017 · 0 comments
Open

Implement signed keys #24

adevore opened this issue Jul 24, 2017 · 0 comments
Assignees
Milestone

Comments

@adevore
Copy link
Owner

adevore commented Jul 24, 2017

Currently, only unsigned integers have the Key trait implemented. The problem with signed integers comes when trying to negative integers into a trie. Because the top bit is 1 in two's complement integers, negative numbers will come after positive numbers if simply transmuted. Instead, the numbers must be shifted in the Key trait implementation.

The feature/signed-keys branch contains an implementation that is verified to work for insert, get, and remove. However, because iteration is not implemented the order has not been verified. This is blocking on #14.

@adevore adevore self-assigned this Jul 24, 2017
@adevore adevore added this to the 0.2 milestone Jul 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant