Fix exponential complexity when reading snapshot map. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous version would run through 3 levels of loops, each across all existing snapshots. Thus, if we had ~1000 snapshots (real-world usage), this would cause a billion iterations. This patch now only iterates over the whole snapshot list exactly once.
winged
force-pushed
the
fix_exponential_complexity_in_read_snapshot_map
branch
from
6e417af
to
491652c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version would run through 3 levels of loops, each across all existing
snapshots. Thus, if we had ~1000 snapshots (real-world usage), this would cause a
billion iterations.
This patch now only iterates over the whole snapshot list exactly once.
This fixes #8